Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #5776 [cluster-autoscaler] "Change magnum to use control-plane role" into CA1.27 #5910

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Backport #5776 [cluster-autoscaler] "Change magnum to use control-plane role" into CA1.27 #5910

merged 2 commits into from
Jul 3, 2023

Conversation

Shubham82
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is cherry-picked, which backports #5776 in CA-1.27

Which issue(s) this PR fixes:

Part of #5888

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
@k8s-ci-robot k8s-ci-robot requested a review from x13n June 29, 2023 07:22
@Shubham82
Copy link
Contributor Author

Hi @BigDarkClown @x13n
PTAL!

@Shubham82 Shubham82 mentioned this pull request Jun 29, 2023
Closed
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2023
@Shubham82
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 3, 2023
@x13n
Copy link
Member

x13n commented Jul 3, 2023

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2023
@x13n
Copy link
Member

x13n commented Jul 3, 2023

/test test-and-verify

@k8s-ci-robot
Copy link
Contributor

@x13n: No presubmit jobs available for kubernetes/[email protected]

In response to this:

/test test-and-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x13n
Copy link
Member

x13n commented Jul 3, 2023

Hm.. test job failed on some timeout, but I don't seem to be able to restart it. Can you kick it with some no-op update?

@Shubham82
Copy link
Contributor Author

Thanks @x13n for looking at this.
Sure I will do it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@Shubham82
Copy link
Contributor Author

@x13n PTAL!

mwielgus
mwielgus approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit cc21718 into kubernetes:cluster-autoscaler-release-1.27 Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, Shubham82, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shubham82 @x13n @k8s-ci-robot @mwielgus