fix: CA on fargate causing log flood #5887
Conversation
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/cluster-autoscaler
size/M
| @@ -55,16 +56,21 @@ func newTestAwsManagerWithMockServices(mockAutoScaling autoScalingI, mockEC2 ec2 | |||
| autoscalingOptions: make(map[AwsRef]map[string]string), | |||
| }, | |||
| } | |||
|
|
|||
| if instanceStatus != nil { | |||
There was a problem hiding this comment.
To pass custom instanceStatus so that it is easy to test HasInstance()
| Name: "node-XXX", | ||
| }, | ||
| Spec: apiv1.NodeSpec{ | ||
| ProviderID: "aws:///us-east-1a/test-instance-id-2", |
There was a problem hiding this comment.
This node has a provider ID which is not present in the asg cache.
- happens when CA tries to check if the unmanaged fargate node is a part of ASG (it isn't) - and keeps on logging error Signed-off-by: vadasambar <[email protected]>
Signed-off-by: vadasambar <[email protected]>
vadasambar
force-pushed
the
fix/5842/fargate-nodes-causing-logs-flood
branch
from
3f9749b to
ec01059
Compare
|
/assign @gjtempleton |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, vadasambar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
May I know which version contains this fix? I've just installed version 1.27.2 on an EKS cluster containing Fargate workload and getting a lot of such warning, the more fargate nodes the more warning messages printed. The version 1.27.3 was out but the latest helm chart at the time of this writing (9.29.1) is still using version 1.27.2 |
|
@tri-bao sorry for the delay.
The fix is only in If you want, I can create cherry-pick PR for 1.27. |
…odes-causing-logs-flood fix: CA on fargate causing log flood
Signed-off-by: vadasambar [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes #5842 (and adds tests)
Which issue(s) this PR fixes:
Fixes #5842
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: