Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't clean CriticalAddonsOnly taint from template nodes #5838

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: don't clean CriticalAddonsOnly taint from template nodes #5838

merged 2 commits into from
Jul 17, 2023

Conversation

vadasambar
Copy link
Member

@vadasambar vadasambar commented Jun 6, 2023 •
edited
Loading

  • this taint leads to unexpected behavior
  • users expect CA to consider the taint when autoscaling

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4097

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed: `CriticalAddonsOnly` taint will not be cleaned from template nodes anymore. This is a *backwards incompatible* change. Check https://github.com/kubernetes/autoscaler/issues/4097 for more information.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@vadasambar
fix: don't clean CriticalAddonsOnly taint from template nodes
7217870 
- this taint leads to unexpected behavior
- users expect CA to consider the taint when autoscaling

Signed-off-by: vadasambar <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2023
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n June 6, 2023 17:58
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@vadasambar vadasambar mentioned this pull request Jun 6, 2023
Closed
@vadasambar
test: fix failing tests
8de66e1 
- remove non-relevant comment related to rescheduler
Signed-off-by: vadasambar <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2023
@vadasambar vadasambar marked this pull request as ready for review July 6, 2023 04:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from BigDarkClown July 6, 2023 04:57
@vadasambar
Copy link
Member Author

vadasambar commented Jul 6, 2023 •
edited
Loading

/assign @MaciekPytel

Added you as reviewer because I think you have the most context on this.

I'd be happy to approve a PR removing it.

#4097 (comment)

@vadasambar vadasambar mentioned this pull request Jul 6, 2023
Closed
@stevehipwell
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@stevehipwell: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vadasambar
Copy link
Member Author

@MaciekPytel waiting for your review.

@vadasambar
Copy link
Member Author

@MaciekPytel waiting for your review.

@MaciekPytel waiting for your review.

@MaciekPytel
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, pierluigilenoci, vadasambar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 686900b into kubernetes:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluigilenoci pierluigilenoci pierluigilenoci approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@x13n x13n Awaiting requested review from x13n

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

Assignees

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cluster-autoscaler] CriticalAddonsOnly taint ignored
5 participants
@vadasambar @stevehipwell @k8s-ci-robot @MaciekPytel @pierluigilenoci