Remove vendor directory

[fmuyassarov]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Drop the following vendor directories

./addon-resizer/vendor
./vertical-pod-autoscaler/vendor
./vertical-pod-autoscaler/e2e/vendor
./cluster-autoscaler/vendor

Which issue(s) this PR fixes:

Fixes #4878

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[fmuyassarov]

/assign @x13n

[fmuyassarov]

Ops, seems I missed my second commit.
/hold

[fmuyassarov]

/hold

[x13n]

This PR is humongous, can you scope it down just to Cluster Autoscaler?

[fmuyassarov]

This PR is humongous, can you scope it down just to Cluster Autoscaler?

Yes I will do so. There is a second commit I had and I was not able to push it yet because I haven't fixed all the failing tests locally yet. Perhaps it would simply it for both me and reviewers.

[x13n]

Thanks! Btw, removing vendor is just a part of the task here - we also need to step referencing it e.g. in Makefile:

autoscaler/cluster-autoscaler/Makefile

Lines 88 to 89 in c2b969d

	test -z "$$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -s -d {} + | tee /dev/stderr)" || \
	test -z "$$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -s -w {} + | tee /dev/stderr)"

[fmuyassarov]

Thanks! Btw, removing vendor is just a part of the task here - we also need to step referencing it e.g. in Makefile:

autoscaler/cluster-autoscaler/Makefile

Lines 88 to 89 in c2b969d

	test -z "$$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -s -d {} + | tee /dev/stderr)" || \
	test -z "$$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -s -w {} + | tee /dev/stderr)"

yes, that I did as part of second commit (which is not pushed here yet).

[jbartosik]

Please remove vendor only for Cluster Autoscaler (now it's removing also addon resizer vendor)

[x13n]

Hey @fmuyassarov , are you still working on this one?

[fmuyassarov]

Hey @fmuyassarov , are you still working on this one?

Hi @x13n . Sorry for the radio silence here. I was busy with some other proprieties. I will have time during the week to rebase and update the PR according to the comments above.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmuyassarov
Once this PR has been reviewed and has the lgtm label, please ask for approval from x13n. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[x13n]

Can we have a warning first? See discussion on #4878

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[x13n]

Looks like this is no longer being worked on, so closing. Feel free to reopen if you have a chance to get back to this.

/close

[k8s-ci-robot]

@x13n: Closed this PR.

In response to this:

Looks like this is no longer being worked on, so closing. Feel free to reopen if you have a chance to get back to this.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.