-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the VPA content for the helm chart and Bump the CA image to 1.27.2 #5763
Modified the VPA content for the helm chart and Bump the CA image to 1.27.2 #5763
Conversation
Hi @gjtempleton, @MaciekPytel |
99ee3ee
to
c34a7a1
Compare
Previously few test cases failed because somehow I missed the pre-commit hook things, update the PR according to that. |
Now only on checking the details of the test case it is showing the following error:
but the latest chart version for CA is already 9.28.0. did I miss something here? @gjtempleton could you please take a look? |
is the problem. You need to bump the chart version to |
but there is no chart version |
@gjtempleton, could you please tell me why we have to change it to 9.28.1 |
We use automated tooling to build and publish the releases of the helm chart: https://github.com/kubernetes/autoscaler/blob/master/.github/workflows/release.yaml#L4-L29 It does this based on the chart-version declared in Chart.yaml, so on merging a PR updating the chart and the chart version, it will create the release, and publish the associated tarball, as well as updating the gh-docs branch to allow discovery of the new version of the chart. |
Thanks for the above info. |
Hi @gjtempleton |
Hi @gjtempleton Thanks |
@gjtempleton Thanks |
Thanks, @gjtempleton, for your above comments. I will rebase it and bump the patch version. |
6acd0f3
to
d47a800
Compare
Hi @gjtempleton |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, Shubham82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
This PR modified the VPA content for the CA under the Charts directory. It will give a better understanding of the usage of VPA for the CA helm charts.
Which issue(s) this PR fixes:
Fixes #5758
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: