Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/asg resource tags for 1.26.x #5722

Merged
merged 1 commit into from
May 7, 2023
Merged

Fix/asg resource tags for 1.26.x #5722

merged 1 commit into from
May 7, 2023

Conversation

paleozogt
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

Applies #5214 to 1.26 (since 1.27 seems like its a long way off from release).

Which issue(s) this PR fixes:

Fixes #5164

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@tombokombo @paleozogt
fix asg resource tags
a5e1dd7 
Signed-off-by: tombokombo <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @paleozogt!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/cluster-autoscaler labels May 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from jaypipes and x13n May 3, 2023 12:31
gjtempleton
gjtempleton reviewed May 3, 2023
View reviewed changes
cluster-autoscaler/main.go Outdated
@@ -396,6 +396,7 @@ func buildAutoscaler(debuggingSnapshotter debuggingsnapshot.DebuggingSnapshotter
nodeInfoComparatorBuilder = nodegroupset.CreateAzureNodeInfoComparator
} else if autoscalingOptions.CloudProviderName == cloudprovider.AwsProviderName {
nodeInfoComparatorBuilder = nodegroupset.CreateAwsNodeInfoComparator
opts.Processors.TemplateNodeInfoProvider = nodeinfosprovider.NewAsgTagResourceNodeInfoProvider(nodeInfoCacheExpireTime, *forceDaemonSets)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
opts.Processors.TemplateNodeInfoProvider = nodeinfosprovider.NewAsgTagResourceNodeInfoProvider(nodeInfoCacheExpireTime, *forceDaemonSets)
opts.Processors.TemplateNodeInfoProvider = nodeinfosprovider.NewAsgTagResourceNodeInfoProvider(nodeInfoCacheExpireTime)

Copy link
Author

@paleozogt paleozogt May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like I brought over a 1.27-ish part of the fix.

@x13n
Copy link
Member

x13n commented May 5, 2023

/lgtm

But leaving approval to aws owners

/assign @gjtempleton @jaypipes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@gjtempleton
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, paleozogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 78c193b into kubernetes:cluster-autoscaler-release-1.26 May 7, 2023
@paleozogt paleozogt deleted the fix/asg-resource-tags-1.26 branch May 7, 2023 23:53
@gjtempleton gjtempleton mentioned this pull request May 8, 2023
Merged
@paleozogt paleozogt mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton gjtempleton left review comments

@jaypipes jaypipes Awaiting requested review from jaypipes

@x13n x13n Awaiting requested review from x13n

Assignees

@jaypipes jaypipes

@x13n x13n

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paleozogt @k8s-ci-robot @x13n @gjtempleton @jaypipes @tombokombo