Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Hetzner Cloud Arm Server Types #5677

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

apricote
Copy link
Member

What type of PR is this?

/kind feature
/area provider/hetzner

Which issue(s) this PR fixes:

Adds support for new APIs and behaviours related to the newly introduced Hetzner Cloud Arm Server Types

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from x13n April 12, 2023 10:04
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@x13n
Copy link
Member

x13n commented Apr 13, 2023

/assign @LKaemmerling @4ND3R50N

Can you review this?

@k8s-ci-robot
Copy link
Contributor

@x13n: GitHub didn't allow me to assign the following users: LKaemmerling, 4ND3R50N.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @LKaemmerling @4ND3R50N

Can you review this?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, LKaemmerling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LKaemmerling
Copy link
Contributor

@x13n This is fine from my side.

@x13n
Copy link
Member

x13n commented Apr 13, 2023

Thanks! LGTMing on your behalf then (since you're not technically a k8s org member):

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9ddc04d into kubernetes:master Apr 13, 2023
@apricote apricote deleted the arm branch April 13, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants