Move MaxNodeProvisionTime to NodeGroupAutoscalingOptions

[morshielt]

Which component does this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR enables setting MaxNodeProvisionTime per NodeGroup (it was previously set per cluster).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Please take a look.

Does this PR introduce a user-facing change?

MaxNodeProvisionTime can now be defined per node group using 'maxnodeprovisiontime' key. The value of 'max-node-provision-time flag' is still used as the default for all node groups, so this change should have no visible impact on the behavior of Cluster Autoscaler.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NA

/assign @kisieland

[k8s-ci-robot]

@morshielt: GitHub didn't allow me to assign the following users: kisieland.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Which component does this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR enables setting MaxNodeProvisionTime per NodeGroup (it was previously set per cluster).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Please take a look.

Does this PR introduce a user-facing change?

MaxNodeProvisionTime can now be defined per node group using 'maxnodeprovisiontime' key. The value of 'max-node-provision-time flag' is still used as the default for all node groups, so this change should have no visible impact on the behavior of Cluster Autoscaler.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NA

/assign @kisieland

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: morshielt / name: Maria (38464b7)

[k8s-ci-robot]

Welcome @morshielt!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

@kisieland: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BigDarkClown]

/assign @BigDarkClown

[BigDarkClown]

/lgtm
/approve

[morshielt]

/assign @towca

[x13n]

I'm not going to block this PR on this, but leaving 2 comments to think about. If you decide to ignore them, just drop the hold.

/approve
/hold

[x13n]

I'm a bit sad we need to keep the entire context as a field here. Could we have an object that is just concerned with saying what max node provision time is for a given node (or nodegroup)? The context would then be kept there, making ClusterStateRegistry easier (well, at least not harder) to reason about.

[morshielt]

Renamed the provider interface to maxNodeProvisionTimeProvider and introduced nodeRegistrationTimeLimitProvider struct containing the provider and context. PTAL :)

[x13n]

Thanks, although my point was really that whether or not the context is used is an implementation detail and doesn't have to be a part of the interface. So, one could imagine a staticMaxNodeProvisionTimeProvider which just returns a constant duration, as well as more advanced implementations depending on a specific use case. Regardless of what implementation of maxNodeProvisionTimeProvider interface is used, CSR should not require context passed to the constructor (i.e. New... function).

[morshielt]

Thank you for the explanation - I've introduced NewDefaultMaxNodeProvisionTimeProvider returning an instance of maxNodeProvisionTimeProvider. It's kept as a field in ClusterStateRegistry and it already contains the context and nodeGroupConfigProcessor when it's assigned, so the NewClusterStateRegistry function signature is mostly back to as it was, it only takes the maxNodeProvisionTimeProvider as an additional argument. Please take a look :)

[x13n]

Thanks, looks good overall, just two comments to consider.

[x13n]

Looks good now, thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown, morshielt, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[morshielt]

/unhold