Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Added the Link for Mirror pods. #5609

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Improvement: Added the Link for Mirror pods. #5609

merged 2 commits into from
Mar 23, 2023

Conversation

Shubham82
Copy link
Contributor

What type of PR is this?

/kind documentation
/kind feature

What this PR does / why we need it:

This PR added the link for Mirror Pods under the Cluster Autoscaler FAQ.

Which issue(s) this PR fixes:

Fixes #5566

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer March 22, 2023 04:03
@k8s-ci-robot k8s-ci-robot requested a review from x13n March 22, 2023 04:03
@Shubham82 Shubham82 mentioned this pull request Mar 22, 2023
Closed
@Shubham82
Copy link
Contributor Author

Hi @feiskyer @x13n
PTAL!

@Shubham82
Copy link
Contributor Author

I have added the link to mirror pods and DaemonSet (all places where it is mentioned) in the FAQ.

mwielgus
mwielgus approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, Shubham82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 44771ef into kubernetes:master Mar 23, 2023
@wafuwafu13 wafuwafu13 mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@x13n x13n Awaiting requested review from x13n

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add info about mirror pods in FAQ
3 participants
@Shubham82 @k8s-ci-robot @mwielgus