Put ScaleUp logic behind an interface

cluster-autoscaler/core/autoscaler.go

@@ -25,6 +25,7 @@ import (
 	"k8s.io/autoscaler/cluster-autoscaler/config"
 	"k8s.io/autoscaler/cluster-autoscaler/context"
 	"k8s.io/autoscaler/cluster-autoscaler/core/scaledown/pdb"
+	"k8s.io/autoscaler/cluster-autoscaler/core/scaleup"
 	"k8s.io/autoscaler/cluster-autoscaler/debuggingsnapshot"
 	"k8s.io/autoscaler/cluster-autoscaler/estimator"
 	"k8s.io/autoscaler/cluster-autoscaler/expander"
@@ -52,6 +53,7 @@ type AutoscalerOptions struct {
 	Backoff                backoff.Backoff
 	DebuggingSnapshotter   debuggingsnapshot.DebuggingSnapshotter
 	RemainingPdbTracker    pdb.RemainingPdbTracker
+	ScaleUpOrchestrator    scaleup.Orchestrator
 }
 
 // Autoscaler is the main component of CA which scales up/down node groups according to its configuration
@@ -82,7 +84,8 @@ func NewAutoscaler(opts AutoscalerOptions) (Autoscaler, errors.AutoscalerError)
 		opts.EstimatorBuilder,
 		opts.Backoff,
 		opts.DebuggingSnapshotter,
-		opts.RemainingPdbTracker), nil
+		opts.RemainingPdbTracker,
+		opts.ScaleUpOrchestrator), nil
 }
 
 // Initialize default options if not provided.

cluster-autoscaler/core/equivalence_groups.go → cluster-autoscaler/core/scaleup/equivalence/groups.go

@@ -14,33 +14,35 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package core
+package equivalence
 
 import (
-	"k8s.io/autoscaler/cluster-autoscaler/utils"
 	"reflect"
 
+	"k8s.io/autoscaler/cluster-autoscaler/utils"
+
 	apiv1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/autoscaler/cluster-autoscaler/processors/status"
 	"k8s.io/autoscaler/cluster-autoscaler/utils/drain"
 	pod_utils "k8s.io/autoscaler/cluster-autoscaler/utils/pod"
 )
 
-type podEquivalenceGroup struct {
-	pods             []*apiv1.Pod
-	schedulingErrors map[string]status.Reasons
-	schedulable      bool
+// PodGroup contains a group of pods that are equivalent in terms of schedulability.
+type PodGroup struct {
+	Pods             []*apiv1.Pod
+	SchedulingErrors map[string]status.Reasons
+	Schedulable      bool
 }
 
-// buildPodEquivalenceGroups prepares pod groups with equivalent scheduling properties.
-func buildPodEquivalenceGroups(pods []*apiv1.Pod) []*podEquivalenceGroup {
-	podEquivalenceGroups := []*podEquivalenceGroup{}
+// BuildPodGroups prepares pod groups with equivalent scheduling properties.
+func BuildPodGroups(pods []*apiv1.Pod) []*PodGroup {
+	podEquivalenceGroups := []*PodGroup{}
 	for _, pods := range groupPodsBySchedulingProperties(pods) {
-		podEquivalenceGroups = append(podEquivalenceGroups, &podEquivalenceGroup{
-			pods:             pods,
-			schedulingErrors: map[string]status.Reasons{},
-			schedulable:      false,
+		podEquivalenceGroups = append(podEquivalenceGroups, &PodGroup{
+			Pods:             pods,
+			SchedulingErrors: map[string]status.Reasons{},
+			Schedulable:      false,
 		})
 	}
 	return podEquivalenceGroups

cluster-autoscaler/core/equivalence_groups_test.go → cluster-autoscaler/core/scaleup/equivalence/groups_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package core
+package equivalence
 
 import (
 	"fmt"