Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): refresh node instance cache when nodegroup not found in deleteCreatedNodesWithErrors #5521

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

qianlei90
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

In #4926, @bpineau have fixed the panic issue in deleteCreatedNodesWithErrors, but CA is still not working until instance cache in clusterstateregistry is refreshed, which may up to 2min.

This PR sync up the instance cache with cloud provider.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @qianlei90!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/cluster-autoscaler labels Feb 20, 2023
@qianlei90 qianlei90 changed the title fix(*): refresh node instance cache when nodegroup not found in delet… fix(*): refresh node instance cache when nodegroup not found in deleteCreatedNodesWithErrors Feb 20, 2023
@qianlei90
Copy link
Contributor Author

qianlei90 commented Feb 20, 2023

/assign @mwielgus

@bpineau
Copy link
Contributor

bpineau commented Feb 20, 2023

Thanks @qianlei90 ; I wondered if we might end up here and force-refreshing in loop, until we get throttled.

Had a look at my fleet's "has no known nodegroup" logs emitted today, they seems to last between a few seconds to a couple minutes (likely, resolved by the scheduled background refreshes) so it seems ok (with that limited dataset).

@qianlei90
Copy link
Contributor Author

@x13n PTAL.

@x13n
Copy link
Member

x13n commented Feb 27, 2023

I think high qps generated by cache refreshes could be addressed by exponential backoff on actual API calls. The PR as is makes sense to me. Thanks @qianlei90 !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qianlei90, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants