Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-autoscaler: support additional Brightbox server groups #5407

Merged
merged 2 commits into from
Feb 6, 2023
Merged

cluster-autoscaler: support additional Brightbox server groups #5407

merged 2 commits into from
Feb 6, 2023

Conversation

NeilW
Copy link
Contributor

@NeilW NeilW commented Jan 10, 2023 •
edited
Loading

cluster-autoscaler/cloudprovider/brightbox

Allows autoscaled servers to be members of further server groups in addition to the default and the scaling group.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The Brightbox provider now recognises an 'additional_groups' key in the configuration ConfigMap.
No changes are required by provider users unless they wish to take advantage of the additional
functionality.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/cluster-autoscaler labels Jan 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n January 10, 2023 10:24
@NeilW
Copy link
Contributor Author

NeilW commented Jan 10, 2023

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2023
@x13n
Copy link
Member

x13n commented Jan 30, 2023

/assign

Not directly related to this change, but can you add an OWNERS file for Brightbox cloudprovider so that Brightbox-specific PRs are sent to people more familiar with this specific cloud provider?

@NeilW NeilW force-pushed the add-additional-groups branch from 6b6c49b to ce601d2 Compare January 30, 2023 10:59
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 30, 2023
@NeilW
Copy link
Contributor Author

NeilW commented Jan 30, 2023

Rebased to current master, and OWNERS file added

@x13n
Copy link
Member

x13n commented Feb 6, 2023

Ah, looks like you need to apply for k8s org membership for OWNERS file change to be valid. You may want to comment out specific OWNERS until then to let this PR merge. Otherwise looks good to me.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NeilW, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
@NeilW NeilW force-pushed the add-additional-groups branch from ce601d2 to 4897ca8 Compare February 6, 2023 13:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@NeilW NeilW force-pushed the add-additional-groups branch 2 times, most recently from a8ec2a7 to ce53f37 Compare February 6, 2023 14:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 6, 2023
NeilW added 2 commits February 6, 2023 14:03
@NeilW
cluster-autoscaler: support additional Brightbox server groups
11a0ee6 
cluster-autoscaler/cloudprovider/brightbox

Allows autoscaled servers to be members of further server groups
in addition to the default and the scaling group.
@NeilW
cluster-autoscaler: add Brightbox provider OWNERS file
c863f8f
@NeilW NeilW force-pushed the add-additional-groups branch from ce53f37 to c863f8f Compare February 6, 2023 14:03
@NeilW
Copy link
Contributor Author

NeilW commented Feb 6, 2023

OWNERS file adjusted and rebased

@x13n
Copy link
Member

x13n commented Feb 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit d0f77ec into kubernetes:master Feb 6, 2023
@NeilW NeilW deleted the add-additional-groups branch February 7, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeilW @x13n @k8s-ci-robot