Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding configurable difference ratios #5402

Conversation

Bryce-Soghigian
Copy link
Member

@Bryce-Soghigian Bryce-Soghigian commented Jan 8, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows us to adjust difference ratios and configure the balance of nodegroupsets.

Which issue(s) this PR fixes:

Fixes #5381

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adding 3 Flags to CA. 
	maxCapacityMemoryDifferenceRatio   = flag.Float64("memory-difference-ratio", 0.015, "Maximum difference in memory capacity between two similar node groups to be considered for balancing. Value is a ratio of the smaller node group's memory capacity.")
	maxFreeDifferenceRatio             = flag.Float64("max-free-difference-ratio", 0.05, "Maximum difference in free resources between two similar node groups to be considered for balancing. Value is a ratio of the smaller node group's free resource.")
	maxAllocatableDifferenceRatio      = flag.Float64("max-allocatable-difference-ratio", 0.05, "Maximum difference in allocatable resources between two similar node groups to be considered for balancing. Value is a ratio of the smaller node group's allocatable resource.")
)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer January 8, 2023 05:37
@k8s-ci-robot k8s-ci-robot requested a review from x13n January 8, 2023 05:37
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2023
@Bryce-Soghigian Bryce-Soghigian changed the title Bsoghigian/adding configurable difference ratios adding configurable difference ratios Jan 8, 2023
@Bryce-Soghigian Bryce-Soghigian force-pushed the bsoghigian/adding-configurable-difference-ratios branch from b5cac4c to 88486f4 Compare January 8, 2023 06:14
@x13n
Copy link
Member

x13n commented Jan 9, 2023

/assign

cluster-autoscaler/config/autoscaling_options.go Outdated Show resolved Hide resolved
cluster-autoscaler/config/autoscaling_options.go Outdated Show resolved Hide resolved
@Bryce-Soghigian Bryce-Soghigian force-pushed the bsoghigian/adding-configurable-difference-ratios branch from 94de8d0 to 8da0c63 Compare January 10, 2023 03:46
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bryce-Soghigian, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@Bryce-Soghigian Bryce-Soghigian force-pushed the bsoghigian/adding-configurable-difference-ratios branch from a470693 to 0f8ed0b Compare January 10, 2023 06:41
@x13n
Copy link
Member

x13n commented Jan 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit b94f340 into kubernetes:master Jan 10, 2023
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/adding-configurable-difference-ratios branch July 18, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase or Allow controlling the value of MaxCapacityMemoryDifferenceRatio when comparing Node Groups
4 participants