Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vendor to v1.26.0-rc.1 #5336

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 29, 2022

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates to 1.26 rc.1 library versions, which allows dropping openstack and heketi libraries (xref kubernetes/community#6992 (comment))

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2022
@liggitt
Copy link
Member Author

liggitt commented Nov 29, 2022

cc @jayantjain93, @MaciekPytel

@liggitt
Copy link
Member Author

liggitt commented Nov 29, 2022

uh.... staging repo v0.26.0-rc.0 tag content doesn't match k/k v1.26.0-rc.0

compare https://github.com/kubernetes/apimachinery/blob/v0.26.0-rc.0/pkg/apis/meta/v1/validation/validation.go and https://github.com/kubernetes/kubernetes/blob/v1.26.0-rc.0/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go

https://github.com/kubernetes/autoscaler/actions/runs/3577027159 is failing with undefined: validation.LabelSelectorValidationOptions because the published apimachinery tag isn't right

@liggitt
Copy link
Member Author

liggitt commented Nov 29, 2022

reported ^^ in kubernetes/kubernetes#114192

@liggitt liggitt changed the title update vendor to v1.26.0-rc.0 update vendor to v1.26.0-rc.1 Dec 1, 2022
@liggitt
Copy link
Member Author

liggitt commented Dec 1, 2022

/assign @jayantjain93 @MaciekPytel

@MaciekPytel
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6000d68 into kubernetes:master Dec 2, 2022
@liggitt liggitt deleted the 1-26-rc.0 branch December 2, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants