chore(cluster-autoscaler/rancher): parametize provider ID

[alcidesmig]

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR parametrizes the Provider ID used in rancher autoscaler to attribute node group to existent nodes.

Which issue(s) this PR fixes:

Fixes #5140

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: alcidesmig / name: Alcides Mignoso (0e768d6, 356571a)

[k8s-ci-robot]

Welcome @alcidesmig!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alcidesmig
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval by writing /assign @feiskyer in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alcidesmig]

@feiskyer @x13n can you take a look?

[mwielgus]

cc: @ctrox @gajicdev @pawelkuc @thirdeyenick

[ctrox]

Thanks @alcidesmig for your PR!

Unfortunately the prefix alone won't fix the issues described in #5140 (comment). For example, for AWS the ProviderID is in the following format: aws:///region/instance-id. So even if we allow the provider to continue here with an aws:/// prefixed ProviderID, it will just fail in the next step where we try to extract the node group name from the node name. For most RKE2 providers, this is sadly not <cluster-name>-<node group name>-<random int>-<random string> as assumed by the code. So I'm not sure how much this PR would actually fix as I'm not aware of any RKE2 providers where the ProviderID has a different prefix but the node name adheres to the assumed "standard". Or do you know of any that work like that @alcidesmig?

In order to fix this issue properly, I think this whole thing needs to be approached differently. I would prefer if the user would not have to worry about configuring this and the provider would just figure everything out by itself. I have already started to work on this but I have not been able to finish it yet as the tests need to be adjusted quite a bit as well. I realize that this is probably not easy to just pick up but if you can wait, I intend to take some time this week to finish this.

[alcidesmig]

Hi, @ctrox!

Got it. I implemented this PR because we're having problems with openstack://<uuid> prefix and, for us, it solves the problem. I agree with you about the "not relying on provider id" and can wait for your solution. If you need help coding it, please let me know.

Thank you for bringing it.

[ctrox]

Opened PR #5361 that should handle this issue more generally.

[k8s-ci-robot]

@alcidesmig: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alcidesmig]

Thank you @ctrox! Closing here...