Pull in VPA changes to 0.12 release branch #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
…ME.md Co-authored-by: Marco Voelz <[email protected]>
With switch to ginkgo v2 timeout are counted differently[1]. With Ginkgo v1 timeout was per-test-suite. Now its for the whole test run. As a result `actuation` [2] tests for `v1` API are timing out. They take a little more than 60 minutes. For example passing run [3] logs first '[v1]' at 19:30:23.701 and the last one at 20:33:44.510. [1] https://onsi.github.io/ginkgo/MIGRATING_TO_V2#timeout-behavior [2] https://k8s-testgrid.appspot.com/sig-autoscaling-vpa#autoscaling-vpa-actuation [3] https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-autoscaling-vpa-actuation/1564683608667459584/build-log.txt
After kubernetes#5151 e2e are still failing because we're still hitting ginkgo timeout
jbartosik
force-pushed
the
roll-up-vpa-0-12
branch
from
be80c3e to
d958830
Compare
|
@mwielgus please take a look |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll up VPA 0.12 release branch to master.
I want to include #5149 in VPA 0.12.0 release. I started doing the release when I noticed that dependencies were in state which may cause problems later (different go version than K8s, different ginkgo version) so I want to have those updates as part of VPA 0.12.0.
After that change e2e were failing. I think only changes needed for e2e to pass were test time out extensions (#5151, #5159). I considered simply rolling up to current state of master branch but (now VPA e2e are passing, see dashboard) but I got presubmit errors on CA helm chart changes so I'm pulling in only VPA changes .
Which component this PR applies to?
VPA
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: