Export metric_server_response like other VPA recommender metrics #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
jbartosik
force-pushed
the
metric_server_responses
branch
from
2cd7324 to
ecc9f01
Compare
k8s-ci-robot
added
size/M
jbartosik
changed the title
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
jbartosik
force-pushed
the
metric_server_responses
branch
from
ecc9f01 to
322be71
Compare
jbartosik
force-pushed
the
metric_server_responses
branch
from
5569ea9 to
7cde47e
Compare
In case we instantiate multiple clients and want to distinguish responses they're getting
jbartosik
force-pushed
the
metric_server_responses
branch
from
7cde47e to
abcbe8f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Merged
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
…nses Export metric_server_response like other VPA recommender metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason for the metric to be exported differently than other metrics
Hyphens in name of the metric caused prometheus errors
Which component this PR applies to?
VPA recommmender
What type of PR is this?
/kind bug
What this PR does / why we need it:
VPA recommender fails to initialize because we call MustRegister on a metric with an invalid name and the registration fails.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: