Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart - Allow cloud config path for AWS provider #5105

Merged
merged 1 commit into from
Aug 25, 2022
Merged

helm chart - Allow cloud config path for AWS provider #5105

merged 1 commit into from
Aug 25, 2022

Conversation

khizunov
Copy link
Contributor

@khizunov khizunov commented Aug 18, 2022 •
edited
Loading

Which component this PR applies to?

helm charts

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow AWS cloud provider to be configured with configuration file e.g endpoints

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 18, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @khizunov!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 18, 2022
@khizunov
Copy link
Contributor Author

/assign @gjtempleton

@khizunov
Copy link
Contributor Author

/assign @feiskyer

@gjtempleton
Copy link
Member

Hey, thanks for the PR, a couple of things to address though:

  1. Can you please bump the version by a minor as we're adding new functionality?
  2. Can we add some docs as to what the example being added shows/how it would be used and split it out into separate objects, as it wasn't clear on an initial read that you were providing both example values for the helm chart and the example config map for the cloud-config.

@khizunov khizunov force-pushed the allow-aws-cloud-config branch from 67094d4 to 24a1a80 Compare August 23, 2022 11:04
@khizunov
Copy link
Contributor Author

@gjtempleton done 👍

@khizunov
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@khizunov: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khizunov
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@khizunov: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khizunov khizunov force-pushed the allow-aws-cloud-config branch from 24a1a80 to cac7937 Compare August 23, 2022 12:37
gjtempleton
gjtempleton reviewed Aug 25, 2022
View reviewed changes
cluster-autoscaler/cloudprovider/aws/README.md Outdated
- name: cloud-config
mountPath: config
```
3. Install (or upgrade) helm chart with updated values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially:

Suggested change
3. Install (or upgrade) helm chart with updated values
3. Install (or upgrade) helm chart with updated values, see [an example here.](examples/values-configmap-example.yaml)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjtempleton thanks for suggestion, done

@khizunov khizunov force-pushed the allow-aws-cloud-config branch from cac7937 to b0ffcce Compare August 25, 2022 09:40
@khizunov khizunov requested review from gjtempleton and removed request for feiskyer August 25, 2022 09:42
@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, khizunov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit b718e74 into kubernetes:master Aug 25, 2022
@BastienM BastienM mentioned this pull request Aug 25, 2022
Closed
SergiySavarin
SergiySavarin reviewed Aug 29, 2022
View reviewed changes
charts/cluster-autoscaler/templates/deployment.yaml
@@ -63,6 +63,9 @@ spec:
{{- if .Values.autoDiscovery.clusterName }}
- --node-group-auto-discovery=asg:tag={{ tpl (join "," .Values.autoDiscovery.tags) . }}
{{- end }}
{{- if .Values.cloudConfigPath }}
Copy link

@SergiySavarin SergiySavarin Aug 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khizunov could you consider to change cloudConfigPath default value here https://github.com/kubernetes/autoscaler/blob/master/charts/cluster-autoscaler/values.yaml#L128.
Currently, it affects autoscaler start up if file not present:

I0829 12:07:52.348973       1 reflector.go:255] Listing and watching *v1.Job from k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes/listers.go:338
I0829 12:07:52.348994       1 reflector.go:219] Starting reflector *v1.StatefulSet (1h0m0s) from k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes/listers.go:356
I0829 12:07:52.349001       1 reflector.go:255] Listing and watching *v1.StatefulSet from k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes/listers.go:356
W0829 12:07:52.364627       1 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
I0829 12:07:52.364817       1 cloud_provider_builder.go:29] Building aws cloud provider.
F0829 12:07:52.364869       1 aws_cloud_provider.go:352] Couldn't open cloud provider configuration /etc/gce.conf: &fs.PathError{Op:"open", Path:"/etc/gce.conf", Err:0x2}
goroutine 30 [running]:
k8s.io/klog/v2.stacks(0x1)
    /gopath/src/k8s.io/autoscaler/cluster-autoscaler/vendor/k8s.io/klog/v2/klog.go:1038 +0x8a
k8s.io/klog/v2.(*loggingT).output(0x611e4e0, 0x3, 0x0, 0xc000565730, 0x0, {0x4d2e584, 0x2}, 0xc0009ea840, 0x0)
    /gopath/src/k8s.io/autoscaler/cluster-autoscaler/vendor/k8s.io/klog/v2/klog.go:987 +0x5fd
k8s.io/klog/v2.(*loggingT).printf(0...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergiySavarin Thanks for the comment, the fix is in PR #5141

navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
@k8s-ci-robot
Merge pull request kubernetes#5105 from khizunov/allow-aws-cloud-config
ce9803c 
helm chart - Allow cloud config path for AWS provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiySavarin SergiySavarin SergiySavarin left review comments

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

Assignees

@feiskyer feiskyer

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khizunov @k8s-ci-robot @gjtempleton @SergiySavarin @jbartosik @feiskyer