Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.22] Automated cherry pick of #4810: Continue CA loop when unregistered nodes were removed #5091

Conversation

FeLvi-zzz
Copy link
Member

Cherry pick of #4810 on cluster-autoscaler-release-1.22.

#4810: Continue CA loop when unregistered nodes were removed

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2022
@FeLvi-zzz FeLvi-zzz changed the title Automated cherry pick of #4810: Continue CA loop when unregistered nodes were removed [release-1.22] Automated cherry pick of #4810: Continue CA loop when unregistered nodes were removed Aug 15, 2022
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FeLvi-zzz, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1f9b4e0 into kubernetes:cluster-autoscaler-release-1.22 Aug 18, 2022
@FeLvi-zzz FeLvi-zzz deleted the automated-cherry-pick-of-#4810-upstream-cluster-autoscaler-release-1.22 branch August 18, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants