Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Scaleway Cloud Provider for k8s CA #5062

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

louisportay
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

this PR upstreams the implementation of the cluster-autoscaler used by the cloud provider Scaleway.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Do not hesitate to ping me on k8s slack channel #sig-autoscaling if anything =)

Does this PR introduce a user-facing change?

k8s users:
NONE

Kapsule users:
Scaleway users will have the choice of managing themselves the cluster-autoscaler pod therefore metrics will be scraped more easily.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

I am happy to answer questions, let me know if you have any suggetions regarding the code.
The implementation has been tested in scaleway environment and is working as expected.

Louis

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 29, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: louisportay / name: Louis Portay (5323047)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @louisportay!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 29, 2022
@louisportay
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 29, 2022
@louisportay
Copy link
Contributor Author

Is it mandatory for me to be part of kubernetes org to submit this pull request ? I thought I heard no during the sig meeting

@gjtempleton
Copy link
Member

@louisportay Sorry, that's my bad, I should have been clearer. If you comment out the users who aren't members of the k8s org currently, as we do with e.g. Civo: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/civo/OWNERS it means we still know who to contact for reviews of the cloudprovider code changes.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 9, 2022
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: louisportay, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 950587b into kubernetes:master Aug 9, 2022
@louisportay
Copy link
Contributor Author

thanks !

navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
add: Scaleway Cloud Provider for k8s CA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants