-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: Scaleway Cloud Provider for k8s CA #5062
Conversation
|
Welcome @louisportay! |
/easycla |
Is it mandatory for me to be part of kubernetes org to submit this pull request ? I thought I heard no during the sig meeting |
@louisportay Sorry, that's my bad, I should have been clearer. If you comment out the users who aren't members of the k8s org currently, as we do with e.g. Civo: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/civo/OWNERS it means we still know who to contact for reviews of the cloudprovider code changes. |
fc14403
to
10c7e2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: louisportay, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks ! |
add: Scaleway Cloud Provider for k8s CA
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
this PR upstreams the implementation of the cluster-autoscaler used by the cloud provider Scaleway.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Do not hesitate to ping me on k8s slack channel #sig-autoscaling if anything =)
Does this PR introduce a user-facing change?
k8s users:
NONE
Kapsule users:
Scaleway users will have the choice of managing themselves the cluster-autoscaler pod therefore metrics will be scraped more easily.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
I am happy to answer questions, let me know if you have any suggetions regarding the code.
The implementation has been tested in scaleway environment and is working as expected.
Louis