-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for azure autodiscovery with autoscaler helm chart. #5051
Add support for azure autodiscovery with autoscaler helm chart. #5051
Conversation
|
Welcome @nclaeys! |
c10f05f
to
e5cce70
Compare
e5cce70
to
12f808f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, nclaeys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…iscovery-azure Add support for azure autodiscovery with autoscaler helm chart.
Which component this PR applies to?
helm chart of the cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
The cluster auto-scaler for Azure supports auto-discovery but the helm chart does not. Added basic support for discovering node groups when using Azure.
Which issue(s) this PR fixes:
/
Special notes for your reviewer:
/
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: