Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switched policy for PodDisruptionBudget from v1beta1 to v1 in time for 1.25 #4990

Merged
merged 1 commit into from
Jun 27, 2022
Merged

switched policy for PodDisruptionBudget from v1beta1 to v1 in time for 1.25 #4990

merged 1 commit into from
Jun 27, 2022

Conversation

mikelo
Copy link
Contributor

@mikelo mikelo commented Jun 24, 2022

…r 1.25

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4285

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2022
@mikelo mikelo mentioned this pull request Jun 24, 2022
Closed
@mikelo
Copy link
Contributor Author

mikelo commented Jun 24, 2022

@yaroslava-serdiuk please review this new single commit PR (I had trouble reopening #4976)

@k8s-ci-robot
Copy link
Contributor

@mikelo: The label(s) /label custer-autoscaler cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label custer-autoscaler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikelo
Copy link
Contributor Author

mikelo commented Jun 24, 2022

/label cluster-autoscaler

@mikelo mikelo closed this Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

@mikelo: The label(s) /label cluster-autoscaler cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label cluster-autoscaler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikelo mikelo reopened this Jun 24, 2022
@yaroslava-serdiuk
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@yaroslava-serdiuk: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaciekPytel
Copy link
Contributor

/lgtm
/approve
Thank for fixing that!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, mikelo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5745044 into kubernetes:master Jun 27, 2022
@mikelo
Copy link
Contributor Author

mikelo commented Jun 27, 2022 •
edited
Loading

/lgtm /approve Thank for fixing that!

thank you for the blazing fast review!

navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
@k8s-ci-robot
Merge pull request kubernetes#4990 from mikelo/issue.4285
ceba124 
switched policy for PodDisruptionBudget from v1beta1 to v1 in time for 1.25
@pacoxu pacoxu mentioned this pull request Mar 13, 2023
Merged
@kevin-bates kevin-bates mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+
4 participants
@mikelo @k8s-ci-robot @yaroslava-serdiuk @MaciekPytel