Various fixes to the OVHcloud provider

[XavierDuthil]

Various bug fixes to the OVHcloud provider:

• Fix silent failure of upscale/downscale due to the node group status being not READY
• Fix Instance.ID to the actual value of Node.Spec.ProviderID
• Fix infinite looping when DecreaseTargetSize is called
• Fix the way we determine to which node group a node belongs to
• Fix handling of non-autoscaled nodepools (now considered as autoscaled nodepools with no margin of action)
• Fix TemplateNodeInfo with correct allocatable resources from the instance flavor specs

Signed-off-by: Xavier Duthil [email protected]

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind bug

What this PR does / why we need it:

Various fixes to the OVHcloud provider (see top of description for the list of fixes).

Those fixes have already been released in production on the OVHcloud Managed Kubernetes product.

Which issue(s) this PR fixes:

Special notes for your reviewer:

This PR is also the continuation from the outdated draft PR #4248.

I squashes all commits for convenience but I can split them back to 5-6 commits if needed.

Does this PR introduce a user-facing change?

## OVHcloud
- Fix node resources during upscaling simulations
- Fix associations between nodes and their node group
- Fix silent failure of upscale/downscale due to the node group status being not READY

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: XavierDuthil / name: Xavier Duthil (2f90257)

[k8s-ci-robot]

Welcome @XavierDuthil!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[mwielgus]

/lgtm
/approve

[mwielgus]

cc: @ricoleabricot

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, XavierDuthil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ricoleabricot]

Well done 🎉