-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the PreFilterResult in SchedulerBasedPredicateChecker #4865
Conversation
|
Welcome @ahaysx! |
/assign @x13n |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahaysx, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use the node names given in the new
PreFilterResult
to skip nodes inFitsAnyNode
.It did not seem ideal to also use the result in
CheckPredicates
. The pre-filter result does not include a message or reason like the filter result, so it would provide less information to the caller to return a generic pre-filter error. Let me know if the intent was to modify this as well.Which issue(s) this PR fixes:
Fixes #4745
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: