Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI cloud provider : Optional Feature - Skip time-consuming findInstanceByDetails API call by adding non_pool_member annotation to the node #4860

Merged
merged 1 commit into from
May 12, 2022
Merged

OCI cloud provider : Optional Feature - Skip time-consuming findInstanceByDetails API call by adding non_pool_member annotation to the node #4860

merged 1 commit into from
May 12, 2022

Conversation

aarontams
Copy link
Contributor

This feature can be turned on by setting environment variable OCI_USE_NON_MEMBER_ANNOTATION to true.

For example, if a node is not belong to any instance pool, during the very first GetInstancePoolForInstance call, the node will be annotated with oci.oraclecloud.com/instancepool-id: non_pool_member.
After new annotation is added to the node, all future GetInstancePoolForInstance calls related to the non-pool-member node will skip the time-consuming findInstanceByDetails API call.

Minor refactoring - when retrieving pool size from instancePoolCache object, use the pool size defined inside the poolCache map instead.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 6, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aarontams / name: Aaron Tam (ae3284e)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 6, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @aarontams!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2022
Optional Feature - Skip time-consuming findInstanceByDetails API call…
ae3284e 
… by adding non_pool_member annotation to the node.

This feature can be turned on by setting environment variable OCI_USE_NON_MEMBER_ANNOTATION to true.

For example, if a node is not belong to any instance pool,
during the very first GetInstancePoolForInstance call, the node will be annotated with
    oci.oraclecloud.com/instancepool-id: non_pool_member
After new annotation is added to the node, all future GetInstancePoolForInstance calls related to
the non-pool-member node will skip the time-consuming findInstanceByDetails API call.

Minor refactoring - when retrieving pool size from instancePoolCache object, use the pool size defined inside the poolCache map instead.
@aarontams aarontams force-pushed the skip-findInstanceByDetails-call-for-annotated-non-pool-member-node branch from 4a8076d to ae3284e Compare May 6, 2022 04:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 6, 2022
@jlamillan
Copy link
Contributor

Thanks for the pull request. Your changes look good to me.

jlamillan
jlamillan approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@jlamillan jlamillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aarontams aarontams changed the title Optional Feature - Skip time-consuming findInstanceByDetails API call by adding non_pool_member annotation to the node OCI cloud provider : Optional Feature - Skip time-consuming findInstanceByDetails API call by adding non_pool_member annotation to the node May 6, 2022
@aarontams
Copy link
Contributor Author

/assign @aleksandra-malinowska

mwielgus
mwielgus approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aarontams, jlamillan, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit a5b5574 into kubernetes:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlamillan jlamillan jlamillan approved these changes

@mwielgus mwielgus mwielgus approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@aleksandra-malinowska aleksandra-malinowska

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aarontams @k8s-ci-robot @jlamillan @mwielgus @jbartosik @aleksandra-malinowska