Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Civo as a cloud provider #4852

Merged
merged 11 commits into from
Aug 8, 2022

Conversation

vishalanarase
Copy link
Member

Hello Kubernetes Community,

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

We are the Civo Kubernetes Team: @vishalanarase, @birdiesanders, and @RealHarshThakur. We worked during the past month to implement a Node Autoscaler for Civo Kubernetes software as a cloud provider, and we're sending it here for broader community use.

It has the basic support you would expect, like increasing and decreasing node groups.

We're here if you have any questions!

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 4, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 4, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @vishalanarase!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 4, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 4, 2022
@mwielgus
Copy link
Contributor

Please sign the CLA. Without the CLA we won't review the PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 1, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2022
Signed-off-by: Vishal Anarse <[email protected]>
Signed-off-by: Vishal Anarse <[email protected]>
Signed-off-by: Vishal Anarse <[email protected]>
@vishalanarase
Copy link
Member Author

@mwielgus Can you please take a look now?

@mwielgus
Copy link
Contributor

mwielgus commented Jun 6, 2022

Please inline all of the dependencies inside the cloud provider directory - see other cloud providers for reference. We don't allow any new cloud provider dependencies in vendor. To pass the OWNER file check please comment out your name (don't remove it as we need to know who to contact for reviews/in case of problems).

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 8, 2022
Signed-off-by: Vishal Anarse <[email protected]>
@vishalanarase
Copy link
Member Author

@mwielgus can you please take a look?

@vishalanarase
Copy link
Member Author

@mwielgus @feiskyer @aleksandra-malinowska Can you please review?

@vishalanarase
Copy link
Member Author

@mwielgus @feiskyer @aleksandra-malinowska Can you please take a look? It's pending for a long time.

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, vishalanarase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit cd2efa4 into kubernetes:master Aug 8, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants