Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ionos cloud sdk #4836

Merged
merged 2 commits into from
May 4, 2022

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Apr 28, 2022

Which component this PR applies to?

cluster-autoscaler

What this PR does / why we need it:

The ionos-cloud SDK was not updated in quite some time and was still using the v5 API. Updated to current latest version v6.0.2.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 28, 2022
@avorima avorima force-pushed the update-ionos-cloud-sdk branch from 9268d9c to 1386214 Compare April 28, 2022 13:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 28, 2022
avorima added 2 commits April 28, 2022 15:43
- Update ionos-cloud SDK to v6.0.2
- Refactor client auth handling
- Remove redundant caching
- Add README sections for rootless podman and generating mocks
@avorima avorima force-pushed the update-ionos-cloud-sdk branch from 1386214 to 4b951d0 Compare April 28, 2022 13:44
@avorima
Copy link
Contributor Author

avorima commented May 2, 2022

/assign @towca

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avorima, mwielgus, piepmatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit b5e4edc into kubernetes:master May 4, 2022
@avorima avorima deleted the update-ionos-cloud-sdk branch May 4, 2022 16:45
k8s-ci-robot added a commit that referenced this pull request May 5, 2022
Cherry-pick #4836 - Update ionos-cloud SDK and refactor
k8s-ci-robot added a commit that referenced this pull request May 5, 2022
Cherry-pick #4836 - Update ionos-cloud SDK and refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants