Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation #4819

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Fix indentation #4819

merged 3 commits into from
Apr 19, 2022

Conversation

bjrowlett2
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes an issue where a malformed template is generated when setting extraVolumeMounts in a values.yaml file.

When values.yaml contains:

extraVolumeMounts:
- name: ssl-certs
  mountPath: /etc/ssl/certs/ca-certificates.crt
  readOnly: true

Generated output is:

          volumeMounts:
                        - mountPath: /etc/ssl/certs/ca-certificates.crt
              name: ssl-certs
              readOnly: true

Error message is:

Error: YAML parse error on cluster-autoscaler/templates/deployment.yaml:
    error converting YAML to JSON: yaml: line 50: did not find expected key

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 19, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @bjrowlett2!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 19, 2022
@bjrowlett2
Copy link
Contributor Author

/assign @gjtempleton

@gjtempleton
Copy link
Member

gjtempleton commented Apr 19, 2022

Thanks for this, have replicated and validated the fix locally.

Will take an action to improve the linting/validation of changes on PRs going forward on these values defaulting to empty objects.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bjrowlett2, gjtempleton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit b8962ac into kubernetes:master Apr 19, 2022
@bjrowlett2 bjrowlett2 deleted the fix-indentation branch April 21, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants