-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation #4819
Fix indentation #4819
Conversation
Welcome @bjrowlett2! |
/assign @gjtempleton |
Thanks for this, have replicated and validated the fix locally. Will take an action to improve the linting/validation of changes on PRs going forward on these values defaulting to empty objects. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bjrowlett2, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind bug
What this PR does / why we need it:
This fixes an issue where a malformed template is generated when setting extraVolumeMounts in a values.yaml file.
When values.yaml contains:
Generated output is:
Error message is:
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: