Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update azure instance types #4818

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

Prashanth684
Copy link
Contributor

with the latest az 2.35 to include the new arm64 instances

/area provider/azure

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Prashanth684!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 18, 2022
@marwanad
Copy link
Member

There's a lot of instances that got removed with your change. Can you revert those?

We try and keep it as an append-only list since the subscription that you ran the instance generation on might not have all instances.

There's a PR in flight to switch to dynamic instance fetching so hopefully that step will no longer be needed.

with the latest az 2.35 to include the new arm64 instances

/area provider/azure
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 19, 2022
@Prashanth684
Copy link
Contributor Author

There's a lot of instances that got removed with your change. Can you revert those?

We try and keep it as an append-only list since the subscription that you ran the instance generation on might not have all instances.

There's a PR in flight to switch to dynamic instance fetching so hopefully that step will no longer be needed.

thanks @marwanad . indeed, i'd forgotten that my specific subscription was not all inclusive. added back the removed instances

@marwanad
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marwanad, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit f6b1274 into kubernetes:master Apr 19, 2022
Prashanth684 added a commit to Prashanth684/machine-api-provider-azure that referenced this pull request Apr 20, 2022
to include new arm instances. xref: kubernetes/autoscaler#4818
Prashanth684 added a commit to Prashanth684/machine-api-provider-azure that referenced this pull request Apr 20, 2022
to include new arm instances. xref: kubernetes/autoscaler#4818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants