-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update azure instance types #4818
Conversation
Welcome @Prashanth684! |
There's a lot of instances that got removed with your change. Can you revert those? We try and keep it as an append-only list since the subscription that you ran the instance generation on might not have all instances. There's a PR in flight to switch to dynamic instance fetching so hopefully that step will no longer be needed. |
with the latest az 2.35 to include the new arm64 instances /area provider/azure
7dad53d
to
9bfb50d
Compare
thanks @marwanad . indeed, i'd forgotten that my specific subscription was not all inclusive. added back the removed instances |
Thank you! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marwanad, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
to include new arm instances. xref: kubernetes/autoscaler#4818
to include new arm instances. xref: kubernetes/autoscaler#4818
with the latest az 2.35 to include the new arm64 instances
/area provider/azure