Introduce extraction of System Architecture from AutoscalerVars #4807
Conversation
k8s-ci-robot
added
kind/feature
| // Arm64 is used if the Architecture is ARM | ||
| Arm64 SystemArchitecture = "arm64" | ||
| // DefaultArch is used if the Architecture is used as a fallback if not passed by AUTOSCALER_ENV_VARS | ||
| DefaultArch SystemArchitecture = Amd64 |
There was a problem hiding this comment.
DefaultArch currently lives in cloudprovider/utils. It isn't really GCE-specific, so why move it here?
There was a problem hiding this comment.
It is similar to DefaultOS. We were using common CA defaults. But since GCE now explicitly support arch, it seems appropriate to use cloudprovider-specific default value (even if the values are the same). We now have cloudspecific ability to control default as well.
This is also similar impl to OS, distribution, image-type.
There was a problem hiding this comment.
Ok, I buy the consistency argument, let's keep it here for now. I'd consider refactoring non-GCP-specific parts (OS, arch) to some common dir in the future though.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jayantjain93, MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Introduce extraction of System Architecture from AutoscalerVars in GCE cloud-provider
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @x13n