-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for deployment annotations to helm chart #4791
feat: add support for deployment annotations to helm chart #4791
Conversation
Welcome @charlie-haley! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR.
One request, and one inform on how to get the PR checks passing.
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charlie-haley, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which component this PR applies to?
helm charts
What type of PR is this?
/kind feature
What this PR does / why we need it:
Due to this issue #4784, we need access to annotations on the Deployment so we can reload the pod every time the workload cluster kubeconfig updates.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?