vpa: admission-controller: add logs for failure to start webhook server #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sedflix <[email protected]>
k8s-ci-robot
added
kind/cleanup
jbartosik
requested changes
Feb 23, 2022
Signed-off-by: sedflix <[email protected]>
jbartosik
approved these changes
Feb 25, 2022
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, mwielgus, sedflix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sedflix [email protected]
Which component this PR applies to?
vertical-pod-autoscaler, admission controller
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds feature to log failure of HTTPS Server Startup
Which issue(s) this PR fixes:
It will help in debugging #4695
Special notes for your reviewer:
I'm not sure about the best practices to follow here.
Does this PR introduce a user-facing change?