FixBug-invalidMetadataUrl-add-getSubscriptionIdFromInstanceMetadata #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
gandhipr
force-pushed
the
prachigandhi-Fix-invalidMetadataUrl-add-getSubscriptionIdFromInstanceMetadata
branch
5 times, most recently
from
f42685d to
611893c
Compare
marwanad
reviewed
Feb 22, 2022
|
/lgtm cc @feiskyer for the go.mod/final approval |
k8s-ci-robot
added
the
lgtm
gandhipr
force-pushed
the
prachigandhi-Fix-invalidMetadataUrl-add-getSubscriptionIdFromInstanceMetadata
branch
from
611893c to
d2bea90
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, gandhipr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@gandhipr we might want to cherry-pick this to 1.23. |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 7, 2022
cherry pick #4689 onto CA-1.23 - FixBug-invalidMetadataUrl-add-getSubscriptionIdFromInstanceMetadata
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4635
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: