Remove disable scale down callback if schedulable pods are found in filter_out_schedulable. #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter_out_schedulable.
k8s-ci-robot
added
kind/feature
|
/assign @x13n |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, olagacek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes it possible for cluster autoscaler to perform scale down on a node group even when there are some schedulable pods that can be fit on other node groups.
Similar change was previously discussed here: #3547 (comment), however in the end it was abandoned.
As currently scale up and scale down use cluster snapshot, scale down is aware that some pods may be scheduled on nodes and it won't remove them.
This was tested in following scenario: there were two node groups, one for workload A, the other for workload B. Shortly after Job A pods finished (triggering scale down), Job B pods started, triggering scale up for node group B. Together with this change and scale down delay after scale up set to 0, there were concurrent scale up and scale down in progress. Scale up and scale down were both successful, so it should be safe to assume this change does not break anything.