Update dependencies to kubernetes 1.23 #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
As of go1.17 both tags are expected to exist simultaneously. Added tags in all cluster autoscaler files. Added verify-gomod.sh exceptions for non-compliant autogenerated VPA files.
CA no longer compiles on go1.16.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fedosin
pushed a commit
to Fedosin/kubernetes-autoscaler
that referenced
this pull request
May 25, 2022
Update dependencies to kubernetes 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes go.mod update, simple import fixes and moving to go 1.17. The move to 1.17 is required, because k8s itself has moved and the dependencies no longer compile using go1.16.
Notably, the go version tag in go.mod is purposefully left at go1.16 (even though it's not what we actually use). This is needed, because go1.17 changes how go.mod work and the upstream kubernetes haven't transitioned to the new go.mod yet (they misrepresent go version in go.mod exactly the same way).
Reference: kubernetes/kubernetes#105563 (comment)
Also added go:build tags matching existing +build tags for all cluster-autoscaler files across different providers. This should have no effect, but it is a part of golang migration to new syntax and both tags is expected by go fmt in go1.17. Added verify-gofmt.sh exceptions for some autogenerated VPA files instead, as VPA shouldn't be built anyway from a CA release branch. Updated verify-boilerplate tooling to be compatible with new tags.