Enables AZURE_CLUSTER_NAME even if .Values.azureUseManagedIdentityExtension is "true". #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
monaka
changed the title
k8s-ci-robot
added
size/L
|
/assign @gjtempleton Hey, thanks for the PR! Can you please squash the commits down to 1, then I'll be happy to get this merged! |
…tension` is "true". And bump to 9.12.0.
|
@gjtempleton Thanks for your review. I rebased and force-pushed. |
|
Thanks for that! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, monaka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables AZURE_CLUSTER_NAME even if .Values.azureUseManagedIdentityExtension is "true".
Which component this PR applies to?
Which autoscaling component hosted in this repository (cluster-autoscaler, vertical-pod-autoscaler, addon-resizer,
helm charts
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
The Helm chart doesn't work in case azureUseManagedIdentiryExtension="true".
As suggested #4323, the environment variable
AZURE_CLUSTER_NAMEseems to be required.Which issue(s) this PR fixes:
Fixes #4323
Special notes for your reviewer:
This PR is just stopping a CrashLoopBackoff.
It might be some more patches required for working cluster-autoscaler perfect.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
none.