Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#4340 -- Update klog to v2 for e2e --part4 #4501

Closed
wants to merge 1 commit into from

Conversation

mallow111
Copy link
Contributor

Issue: #4340
This PR is to upgrade klog to v2 in vertical-pod-autoscaler/e2e and this is the last part for upgrade, there are a lot of vendor files make the big size bigger.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mallow111
To complete the pull request process, please assign krzysied after the PR has been reviewed.
You can assign the PR to them by writing /assign @krzysied in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty big change - is it necessary to update vendor here?

@mallow111
Copy link
Contributor Author

@jbartosik I did

go mod tidy

it updated the vendor automatically, also the test-to-verfiy failed, is there any other cmd that I should try in local?

@mallow111
Copy link
Contributor Author

@jbartosik please advise if there is any other cmd that I should run

@mallow111
Copy link
Contributor Author

will close this one, it is a duplicate of #4536

@mallow111 mallow111 closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants