Change the behaviour of Garbage Collector of AggregateCollectionStates #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
jbartosik
requested changes
Dec 2, 2021
piotrnosek
force-pushed
the
vpa-gc-controller-two
branch
from
f86c824 to
105ad3d
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Ready for review. Sorry for the confusion - I moved desired changes from #4425 to here due to running into git rebase hell I couldn't manage to fix. |
piotrnosek
force-pushed
the
vpa-gc-controller-two
branch
from
105ad3d to
9c54eef
Compare
jbartosik
requested changes
Dec 20, 2021
AggregateCollectionsStates for which corresponding owner controller doesn't exist anymore.
piotrnosek
force-pushed
the
vpa-gc-controller-two
branch
from
9c54eef to
d03624b
Compare
Closed
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, piotrnosek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the notion of contributive Pods - such that the Pod is either active or as an existing associated controller.
Remove only AggregateCollectionStates which don't have any contributive Pod.