Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand CAPI_GROUP usage to cover other capi group variables #4451

Merged
merged 1 commit into from
Nov 10, 2021
Merged

expand CAPI_GROUP usage to cover other capi group variables #4451

merged 1 commit into from
Nov 10, 2021

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Nov 8, 2021 •
edited
Loading

This change updates the logic for the clusterapi autoscaler provider so
that the CAPI_GROUP environment variable will also affect the
annotations keys for minimum and maximum node group size, the machine
annotation, machine deletion, and the cluster name label. It also addes
unit tests and an update to the readme.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Nov 8, 2021

/assign @enxebre

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@elmiko elmiko force-pushed the expand-capi-group branch from 361f3c1 to c726da7 Compare November 8, 2021 19:48
@elmiko elmiko changed the title expand CAPI_GROUP usage to cover annotations expand CAPI_GROUP usage to cover node group size annotations Nov 8, 2021
@enxebre
Copy link
Member

enxebre commented Nov 9, 2021

should this also affect https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_nodegroup.go#L35-L36 and https://github.com/kubernetes/autoscaler/pull/4451/files#diff-8266b9d377a9df07645393a09139352c01636b7c84b6678586245e72c69dfe45R32 ?

@enxebre
Copy link
Member

enxebre commented Nov 9, 2021

slightly related I created #4453

@elmiko
Copy link
Contributor Author

elmiko commented Nov 9, 2021

should this also affect https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_nodegroup.go#L35-L36 and https://github.com/kubernetes/autoscaler/pull/4451/files#diff-8266b9d377a9df07645393a09139352c01636b7c84b6678586245e72c69dfe45R32 ?

yeah, i can clean those up as well. i was mainly focused on the min/max annotations, but i think it makes sense to set all of these.

@elmiko
expand CAPI_GROUP usage to cover other capi group variables
755cb1b 
This change updates the logic for the clusterapi autoscaler provider so
that the `CAPI_GROUP` environment variable will also affect the
annotations keys for minimum and maximum node group size, the machine
annotation, machine deletion, and the cluster name label. It also addes
unit tests and an update to the readme.
@elmiko elmiko force-pushed the expand-capi-group branch from c726da7 to 755cb1b Compare November 9, 2021 21:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021
@elmiko elmiko changed the title expand CAPI_GROUP usage to cover node group size annotations expand CAPI_GROUP usage to cover other capi group variables Nov 9, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Nov 9, 2021

update

  • add machine annotation key
  • add machine deletion annotation key
  • add cluster name label

@randomvariable
Copy link
Member

this is mostly a lgtm from me, but defer to @enxebre for final lgtm.

@enxebre
Copy link
Member

enxebre commented Nov 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit f2bfbf6 into kubernetes:master Nov 10, 2021
@enxebre
Copy link
Member

enxebre commented Nov 10, 2021 •
edited
Loading

@elmiko although changing the group is recommended only for testing purposes this is technically a breaking change for the annotations we are now including within the swappable apigroup. Please let's make sure we include a proper release note.

@elmiko
Copy link
Contributor Author

elmiko commented Nov 10, 2021

ack, thanks for the heads up @enxebre

@elmiko elmiko deleted the expand-capi-group branch November 10, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunmk arunmk Awaiting requested review from arunmk

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elmiko @k8s-ci-robot @enxebre @randomvariable @jbartosik