Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade image tag version for helm chart #4417

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Upgrade image tag version for helm chart #4417

merged 3 commits into from
Nov 1, 2021

Conversation

Sebor
Copy link
Contributor

@Sebor Sebor commented Oct 22, 2021

Because version 1.21.1 has been released it would be nice to update helm chart

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2021
@gjtempleton
Copy link
Member

Hi, thanks for the PR and for contributing!

Unfortunately our CI doesn't currently automatically run for first-time contributors to the repo otherwise it would have highlighted this, but you'll need to run helm-docs to update the readme with the new default value of the image tag. This can be done by installing helm-docs and running helm-docs cluster-autoscaler from the root of the repo.

(This can also be set up to run automatically using our pre-commit config: https://github.com/kubernetes/autoscaler/tree/master/charts#pre-commit-hooks )

@gjtempleton
Copy link
Member

/assign @gjtempleton

@Sebor
Copy link
Contributor Author

Sebor commented Oct 28, 2021

Hi, thanks for the PR and for contributing!

Unfortunately our CI doesn't currently automatically run for first-time contributors to the repo otherwise it would have highlighted this, but you'll need to run helm-docs to update the readme with the new default value of the image tag. This can be done by installing helm-docs and running helm-docs cluster-autoscaler from the root of the repo.

(This can also be set up to run automatically using our pre-commit config: https://github.com/kubernetes/autoscaler/tree/master/charts#pre-commit-hooks )

Hi, @gjtempleton !
Done

@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, Sebor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1189b0d into kubernetes:master Nov 1, 2021
@Sebor Sebor deleted the update-chart-version branch November 2, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants