-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade image tag version for helm chart #4417
Conversation
Hi, thanks for the PR and for contributing! Unfortunately our CI doesn't currently automatically run for first-time contributors to the repo otherwise it would have highlighted this, but you'll need to run helm-docs to update the readme with the new default value of the image tag. This can be done by installing helm-docs and running (This can also be set up to run automatically using our pre-commit config: https://github.com/kubernetes/autoscaler/tree/master/charts#pre-commit-hooks ) |
/assign @gjtempleton |
Hi, @gjtempleton ! |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, Sebor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because version 1.21.1 has been released it would be nice to update helm chart