Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI instance-pool based cloud provider #4349

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

jlamillan
Copy link
Contributor

Hello Community,

This pull-request adds support for a node autoscaler for Oracle Cloud Infrastructure (OCI) that uses Instance Pools
combined with Instance Configurations.

It's currently being used internally as well as by a couple of early access customers who are using it in combination with Rancher/RKE. We'd like to subset it here for broader community use.

It has the basic support you would expect - automatically adjusting the number of instances in the configured instance pool(s) based on Kubernetes resource, affinity, requirements, etc.

We're here if you have any questions!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @jlamillan!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2021
@jlamillan
Copy link
Contributor Author

FYI @ericrrath

@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 0e42e5f to 4f57da9 Compare September 25, 2021 01:17
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2021
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 4f57da9 to 5d3639d Compare October 27, 2021 20:57
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2021
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 5d3639d to 8224d3e Compare November 9, 2021 00:32
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2021
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 8224d3e to 070314a Compare November 23, 2021 19:38
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2021
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 070314a to e383e26 Compare November 23, 2021 20:03
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from e383e26 to 4e006f3 Compare November 30, 2021 22:24
@jlamillan
Copy link
Contributor Author

/assign @aleksandra-malinowska

@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch 3 times, most recently from 281ca46 to 1029620 Compare December 7, 2021 22:52
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch 5 times, most recently from 70aeeac to 005ef95 Compare December 21, 2021 20:24
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 005ef95 to f30133c Compare January 7, 2022 19:37
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from f30133c to 1126344 Compare January 14, 2022 21:33
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 1126344 to b2b797b Compare January 18, 2022 18:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from b2b797b to 9789b67 Compare January 18, 2022 19:25
@EladGabay
Copy link

Hey, any plans to merge this soon? :) @jlamillan

@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 9789b67 to 103eb83 Compare January 24, 2022 23:50
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 24, 2022
@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 103eb83 to 2359564 Compare January 25, 2022 00:10
@mwielgus
Copy link
Contributor

We don't accept any new dependencies for new cloud providers. Please put all required dependencies into you cloud provider directory.

@mwielgus
Copy link
Contributor

Moreover, inside OWNERS, please comment out people who are not in K8S organization. So that we pass globally imposed validation and know who to contact for reviews.

@jlamillan
Copy link
Contributor Author

jlamillan commented Jan 25, 2022

We don't accept any new dependencies for new cloud providers. Please put all required dependencies into you cloud provider directory.

@mwielgus, all files and the OCI SDK are already stored in cluster-autoscaler/cloudprovider/oci/ directory. Was there something else you were referring to?

@jlamillan jlamillan force-pushed the jlamillan/oci-provider branch from 2359564 to 65ebd8d Compare January 25, 2022 16:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 25, 2022
@jlamillan
Copy link
Contributor Author

Moreover, inside OWNERS, please comment out people who are not in K8S organization. So that we pass globally imposed validation and know who to contact for reviews.

commented out.

@EladGabay
Copy link

@jlamillan hey, is it possible to use "nodepool" instead of "instancepool"?
I mean, the same as in https://docs.oracle.com/en-us/iaas/Content/ContEng/Tasks/contengusingclusterautoscaler.htm

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlamillan, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit ea565af into kubernetes:master Feb 7, 2022
@EladGabay
Copy link

@jlamillan Congrats :)
Any plans to add nodepool option instead of instance-pool?
Thanks!

@jlamillan
Copy link
Contributor Author

@EladGabay
Copy link

@jlamillan thanks, I already use that version. I'm looking for its source code so I'll able to add some modification to my use case. Any chance to get it?

@jlamillan
Copy link
Contributor Author

@EladGabay

I believe that team has plans to release it at some point, but it is not available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants