Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaler from aws examples errors with csidrivers and csistoragecapacities #4262

Closed
wants to merge 1 commit into from
Closed

Autoscaler from aws examples errors with csidrivers and csistoragecapacities #4262

wants to merge 1 commit into from

Conversation

DmitriyStoyanov
Copy link

@DmitriyStoyanov DmitriyStoyanov commented Aug 13, 2021

Added missing rules for csidrivers and csistoragecapacities in aws examples
which used in documentation of installation https://docs.aws.amazon.com/eks/latest/userguide/cluster-autoscaler.html
but we have errors in autoscaler logs such as
0813 09:04:42.593671 1 reflector.go:138] k8s.io/client-go/informers/factory.go:134: Failed to watch *v1beta1.CSIStorageCapacity: failed to list *v1beta1.CSIStorageCapacity: csistoragecapacities.storage.k8s.io is forbidden: User system:serviceaccount:kube-system:cluster-autoscaler cannot list resource csistoragecapacities in API group storage.k8s.io at the cluster scope
or
E0813 09:04:42.594510 1 reflector.go:138] k8s.io/client-go/informers/factory.go:134: Failed to watch *v1.CSIDriver: failed to list *v1.CSIDriver: csidrivers.storage.k8s.io is forbidden: User system:serviceaccount:kube-system:cluster-autoscaler cannot list resource csidrivers in API group storage.k8s.io at the cluster scope

It was fixed in issue #4114 but only for helm chart, and not for aws examples, so this MR to fix the issue

- added missing rules for csidrivers and csistoragecapacities in aws examples
which used in documentation of installation https://docs.aws.amazon.com/eks/latest/userguide/cluster-autoscaler.html
but we have errors in autoscaler logs such as
0813 09:04:42.593671       1 reflector.go:138] k8s.io/client-go/informers/factory.go:134: Failed to watch *v1beta1.CSIStorageCapacity: failed to list *v1beta1.CSIStorageCapacity: csistoragecapacities.storage.k8s.io is forbidden: User system:serviceaccount:kube-system:cluster-autoscaler cannot list resource csistoragecapacities in API group storage.k8s.io at the cluster scope
or
E0813 09:04:42.594510       1 reflector.go:138] k8s.io/client-go/informers/factory.go:134: Failed to watch *v1.CSIDriver: failed to list *v1.CSIDriver: csidrivers.storage.k8s.io is forbidden: User system:serviceaccount:kube-system:cluster-autoscaler cannot list resource csidrivers in API group storage.k8s.io at the cluster scope
It was fixed in issue #4114 but only for helm chart, and not for aws examples
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @DmitriyStoyanov!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2021
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer August 13, 2021 11:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DmitriyStoyanov
To complete the pull request process, please assign gjtempleton after the PR has been reviewed.
You can assign the PR to them by writing /assign @gjtempleton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from Jeffwan August 13, 2021 11:21
@gjtempleton
Copy link
Member

Hey, thanks for the PR, however, this is a duplicate of #4246, which has now been merged.

As such, closing as a duplicate.
/close

@k8s-ci-robot
Copy link
Contributor

@gjtempleton: Closed this PR.

In response to this:

Hey, thanks for the PR, however, this is a duplicate of #4246, which has now been merged.

As such, closing as a duplicate.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants