Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use highest available magnum microversion #4261

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Use highest available magnum microversion #4261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cluster-autoscaler/cloudprovider/magnum/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ using the cluster autoscaler v1.18 or lower.

## Updates

* CA 1.22
* Allow scaling node groups to 0 nodes, if supported (requires Magnum Wallaby).
* CA 1.19
* Update to support Magnum node groups (introduced in Magnum Train).
* Add node group autodiscovery based on the group's role property.
Expand Down
6 changes: 5 additions & 1 deletion cluster-autoscaler/cloudprovider/magnum/magnum_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ import (
const (
// Magnum microversion that must be requested to use the node groups API.
microversionNodeGroups = "1.9"
// Magnum microversion that must be requested to support scaling node groups to 0 nodes.
microversionScaleToZero = "1.10"
// Magnum interprets "latest" to mean the highest available microversion.
microversionLatest = "latest"
)

// magnumManager is an interface for the basic interactions with the cluster.
Expand Down Expand Up @@ -61,7 +65,7 @@ func createMagnumManager(configReader io.Reader, discoverOpts cloudprovider.Node
return nil, err
}

clusterClient.Microversion = microversionNodeGroups
clusterClient.Microversion = microversionLatest

// This replaces the cluster name with a UUID if the name was given in the parameters.
err = checkClusterUUID(provider, clusterClient, opts)
Expand Down