cluster-autoscaler: fix unit tests #4235
Merged
+27
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bpineau
changed the title
Recent changes configured providers to set stable nodes labels names exclusively (ie. LabelTopologyZone and not LabelZoneFailureDomain, etc), with older labels names backfilled at nodeInfos templates generation time (from GetNodeInfoFromTemplate), which isn't invoked from most tests cases. GCE NodePirce() might have been dereferencing potentially missing labels. And run hack/update-gofmt.sh where hack/verify-all.sh fails, to pass CI.
bpineau
force-pushed
the
fix-tests-and-gcp-pricing
branch
from
7be767b to
79c63a7
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpineau, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
evansheng
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Mar 26, 2022
…cing cluster-autoscaler: fix unit tests
evansheng
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Mar 26, 2022
…cing cluster-autoscaler: fix unit tests
jiancheung
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Jul 29, 2022
…cing cluster-autoscaler: fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes configured providers to set stable nodes labels names
exclusively (ie. LabelTopologyZone and not LabelZoneFailureDomain, etc),
with older labels names backfilled at nodeInfos templates generation time
(from GetNodeInfoFromTemplate), which isn't invoked from most tests cases.
GCE NodePirce() might have been dereferencing potentially missing labels.
And run hack/update-gofmt.sh where hack/verify-all.sh fails, to pass CI.