Metrics for AWS API calls #4179
Conversation
Provide metrics for AWS API calls; helps identifying slowness, throttling causes, and errors surges.
k8s-ci-robot
added
cncf-cla: yes
|
@gjtempleton may I request your input on that one? |
| Namespace: caNamespace, | ||
| Name: "aws_request_duration_seconds", | ||
| Help: "Time taken by AWS requests, by method and status code, in seconds", | ||
| Buckets: []float64{0.05, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0, 2.0, 5.0, 10.0, 20.0, 30.0, 60.0}, |
There was a problem hiding this comment.
I'm very slightly worried about the number of histogram buckets here, though the low number of endpoint label values is making me less concerned.
Do we have any idea of the potential cardinality of the status label?
There was a problem hiding this comment.
Yes, I run (a slightly older version of) this patch for over a year on all clusters, managing several thousand ASGs. Got those 10 distinct status over last 12 months:
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpineau, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Metrics for AWS API calls
Metrics for AWS API calls
Metrics for AWS API calls
Provide metrics for AWS API calls; helps identifying slowness, throttling causes, and errors bursts.
That's similar to what GCE provider does.