Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to AWS readme if taint has value #4050

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

afirth
Copy link
Member

@afirth afirth commented Apr 29, 2021

/area provider/aws
Maybe helps #2434 - TBD in the issue

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2021
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and towca April 29, 2021 10:54
@gjtempleton
Copy link
Member

Thanks for the PR!

I'm not clear on how this resolves #2434 though.

@afirth
Copy link
Member Author

afirth commented May 4, 2021

Thanks for the PR!

I'm not clear on how this resolves #2434 though.

As far as I could tell, all comments in that issue were a) expecting CAS to taint new nodes b) failing to specify the Effect or c) using a taint which is ignored by scheduler.
Basically, working as designed I think. For most/all of those comments I think seeing this doc would solve their issue

@afirth
Copy link
Member Author

afirth commented May 7, 2021

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 7, 2021
@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 5, 2021
@afirth
Copy link
Member Author

afirth commented Aug 5, 2021

/remove-lifecycle stale

Not sure what's against merging this.. want me to remove the /fix?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 5, 2021
@gjtempleton
Copy link
Member

Yeah, let's remove the fixes, merge this, and confirm whether it does resolve the issue with those who had commented in the issue rather than assuming it resolves all of the user queries in there.

@afirth
Copy link
Member Author

afirth commented Aug 5, 2021

Done :)

@gjtempleton
Copy link
Member

Thanks! And thanks for persisting with this.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afirth, gjtempleton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit ca49c2c into kubernetes:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants