-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example to AWS readme if taint has value #4050
Conversation
Thanks for the PR! I'm not clear on how this resolves #2434 though. |
As far as I could tell, all comments in that issue were a) expecting CAS to taint new nodes b) failing to specify the |
/kind documentation |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale Not sure what's against merging this.. want me to remove the /fix? |
Yeah, let's remove the |
Done :) |
Thanks! And thanks for persisting with this. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afirth, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/aws
Maybe helps #2434 - TBD in the issue