Brightbox cluster autoscaler provider

[NeilW]

Hello,

Here is the implementation of the Brightbox cloud provider . We've been running this provider as a fork for several versions now and we feel it is now stable enough to be submitted to the mainline.

Comments appreciated

[k8s-ci-robot]

Welcome @NeilW!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[NeilW]

@towca @aleksandra-malinowska do I need to do anything else to get this PR looked at?

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, NeilW

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BigDarkClown]

This PR was reversed in #4410. The code added here does not pass lint & spell checking unit tests, causing unit-test failures in repository. Please clean up your cloudprovider implementation before adding it again.

[NeilW]

@BigDarkClown Was there any particular reason you decided to do that for us rather than excluding the vendored subdirectories in the hack files as has been done for other cloud providers?

autoscaler/hack/verify-spelling.sh

Line 26 in e80ab51

git ls-files --full-name | grep -v -e vendor | grep -v cluster-autoscaler/cloudprovider/magnum/gophercloud| grep -v cluster-autoscaler/cloudprovider/huaweicloud/huaweicloud-sdk-go-v3 | grep -v cluster-autoscaler/cloudprovider/digitalocean/godo | grep -v cluster-autoscaler/cloudprovider/hetzner/hcloud-go | grep -v cluster-autoscaler/cloudprovider/bizflycloud/gobizfly | xargs misspell -error -o stderr

autoscaler/hack/verify-golint.sh

Line 30 in e80ab51

'cluster-autoscaler/cloudprovider/bizflycloud/gobizfly'

autoscaler/hack/boilerplate/boilerplate.py

Line 152 in e80ab51

"cluster-autoscaler/cloudprovider/bizflycloud/gobizfly",

@mwielgus

[NeilW]

I've added the necessary exclusions in #4413