fix: add missing call to fetch autodiscovered nodegroups #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/azure
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marwanad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
marwanad
force-pushed
the
fix-autodiscovery-add-missing-call
branch
from
e988297 to
b5c5c50
Compare
marwanad
commented
Mar 24, 2021
| @@ -135,6 +135,7 @@ func TestNodeGroupForNode(t *testing.T) { | |||
|
|
|||
| registered := provider.azureManager.RegisterNodeGroup( | |||
| newTestScaleSet(provider.azureManager, "test-asg")) | |||
| provider.azureManager.explicitlyConfigured["test-asg"] = true | |||
There was a problem hiding this comment.
this is needed because the manager setup logic skips createAzureManagerInternal and thus by the time fetchAutoNodegroups is called explicitlyConfigured will be empty and the nodegroup will be unregistered on L217 in azure_manager.
marwanad
force-pushed
the
fix-autodiscovery-add-missing-call
branch
from
b5c5c50 to
8d365c2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #3717 missed adding this method to fetch and register auto-discovered groups.
/area provider/azure