Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change thresholds for evicting pods in VPA #3962

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Allow users to change thresholds for evicting pods in VPA #3962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,11 @@ import (
"k8s.io/klog"
)

const (
// Ignore change priority that is smaller than 10%.
defaultUpdateThreshold = 0.10
// Pods that live for at least that long can be evicted even if their
// request is within the [MinRecommended...MaxRecommended] range.
podLifetimeUpdateThreshold = time.Hour * 12
)

var (
defaultUpdateThreshold = flag.Float64("pod-update-threshold", 0.1, "Ignore updates that have priority lower than the value of this flag")

podLifetimeUpdateThreshold = flag.Duration("in-recommendation-bounds-eviction-lifetime-threshold", time.Hour*12, "Pods that live for at least that long can be evicted even if their request is within the [MinRecommended...MaxRecommended] range")

evictAfterOOMThreshold = flag.Duration("evict-after-oom-threshold", 10*time.Minute,
`Evict pod that has only one container and it OOMed in less than
evict-after-oom-threshold since start.`)
Expand Down Expand Up @@ -72,7 +68,7 @@ func NewUpdatePriorityCalculator(vpa *vpa_types.VerticalPodAutoscaler,
recommendationProcessor vpa_api_util.RecommendationProcessor,
priorityProcessor PriorityProcessor) UpdatePriorityCalculator {
if config == nil {
config = &UpdateConfig{MinChangePriority: defaultUpdateThreshold}
config = &UpdateConfig{MinChangePriority: *defaultUpdateThreshold}
}
return UpdatePriorityCalculator{
vpa: vpa,
Expand Down Expand Up @@ -129,7 +125,7 @@ func (calc *UpdatePriorityCalculator) AddPod(pod *apiv1.Pod, now time.Time) {
klog.V(2).Infof("not updating pod %v/%v, missing field pod.Status.StartTime", pod.Namespace, pod.Name)
return
}
if now.Before(pod.Status.StartTime.Add(podLifetimeUpdateThreshold)) {
if now.Before(pod.Status.StartTime.Add(*podLifetimeUpdateThreshold)) {
klog.V(2).Infof("not updating a short-lived pod %v/%v, request within recommended range", pod.Namespace, pod.Name)
return
}
Expand Down