Set different hostname label for upcoming nodes #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function copying template node to use for upcoming nodes was not chaning hostname label, meaning that features relying on this label (ex. pod antiaffinity on hostname topology) would treat all upcoming nodes as a single node. This resulted in triggering too many scale-ups for pods using such features. Analogous function in binpacking didn't have the same bug (but it didn't set unique UID or pod names). I extracted the functionality to a util function used in both places to avoid the two functions getting out of sync again.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, vivekbagade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
drmorr0
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Sep 1, 2021
Set different hostname label for upcoming nodes
drmorr0
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Sep 1, 2021
Set different hostname label for upcoming nodes
evansheng
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Sep 17, 2021
Set different hostname label for upcoming nodes -- make change backwards compatible with breaking schedulernodeinfo to schedulerframework change according to kubernetes@73a5cdf
evansheng
added a commit
to airbnb/autoscaler
that referenced
this pull request
Sep 22, 2021
Backport: Merge pull request kubernetes#3883 from MaciekPytel/fix_antiaffinity
drmorr0
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Jan 13, 2022
Set different hostname label for upcoming nodes
evansheng
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Mar 24, 2022
Set different hostname label for upcoming nodes
This was referenced Jul 10, 2022
jiancheung
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Jul 29, 2022
Set different hostname label for upcoming nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function copying template node to use for upcoming nodes was
not chaning hostname label, meaning that features relying on
this label (ex. pod antiaffinity on hostname topology) would
treat all upcoming nodes as a single node.
This resulted in triggering too many scale-ups for pods
using such features. Analogous function in binpacking didn't
have the same bug (but it didn't set unique UID or pod names).
I extracted the functionality to a util function used in both
places to avoid the two functions getting out of sync again.
I suspect this may have also been the root cause for #3721.